Allow chunked uploads even if your quota is not sufficient #12022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11485 This allows uploads to shared folders. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
nickvergessen,
MorrisJobke,
icewind1991 and
ChristophWurst
|
@lubo @neeral85 @loeffelpan please have a look as well |
MorrisJobke
reviewed
Oct 24, 2018
| @@ -83,7 +83,7 @@ protected function getSize($path, $storage = null) { | |||
| * @return int | |||
| */ | |||
| public function free_space($path) { | |||
| if ($this->quota < 0 || strpos($path, 'cache') === 0) { | |||
| if ($this->quota < 0 || strpos($path, 'cache') === 0 || strpos($path, 'uploads') === 0) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
No. Because that would be files/uploads
There was a problem hiding this comment.
Ah ... missed that part. My brain was faster than I could read. It autocompleted to !== false
icewind1991
approved these changes
Oct 24, 2018
This was referenced Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11485
This allows uploads to shared folders.
To test just follow the steps in #11485