Fix SCSS variable management with the theming app #10924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…culate color values Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
skjnldsv,
rullzer,
weeman1337 and
jancborchardt
skjnldsv
approved these changes
Aug 29, 2018
weeman1337
approved these changes
Aug 29, 2018
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/10901/theming-bugfix-primary
branch
from
3f54510 to
5bae5bf
Compare
nickvergessen
approved these changes
Aug 30, 2018
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @skjnldsv this way we can make sure, that all color calculations in the variables.scss can also use the values from the theming app.
This also fixes #10901
Before
Regular
Hover
After
Regular:
Hover:
