Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share API: create federated share, remove it, but it remains accessible via API #9028

Closed
tobiasKaminsky opened this issue Mar 29, 2018 · 7 comments
Closed

Share API: create federated share, remove it, but it remains accessible via API #9028

tobiasKaminsky opened this issue Mar 29, 2018 · 7 comments
Labels
bug feature: sharing
Milestone
Nextcloud 14

Comments

@tobiasKaminsky
Copy link
Member

I found this via our automated tests on android, using share API on master branch:
(all handled via android-library calls)

  • upload a file
  • create federated share from test@localhost/nc to admin@localhost/nc13 with no password
  • remove file
  • get shares
    -> see created share, but directs to "/" instead of previous file.

Screenshot of (via android library) created & shared file:

screenshot_20180329_165452

Showing result of share API:
screenshot_20180329_165630

"Shared with others" on web UI:
image
@MorrisJobke
Copy link
Member

cc @nextcloud/sharing

@rullzer
Copy link
Member

rullzer commented Apr 4, 2018

who removes the file @tobiasKaminsky ?

@tobiasKaminsky
Copy link
Member Author

The test case with the same credentials via android library.

@MorrisJobke
Copy link
Member

The test case with the same credentials via android library.

I guess he meant if this was removed by the owner or a different person ;)

@tobiasKaminsky
Copy link
Member Author

All is done by the same user:

  • upload a file
  • create federated share from test@localhost/nc to admin@localhost/nc13 with no password
  • remove file
  • get shares

rullzer added a commit that referenced this issue Apr 4, 2018
@rullzer
When formatting a share node an Empty target is invalid
d6cda3f 
Fixes #9028

For federated shares the share table holds no target information (since
it is on the other server). So when a node is actually invalid and not
found we should not display it anymore in the shared with sections etc
and thus throw the proper exceptions.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer mentioned this issue Apr 4, 2018
Merged
@rullzer
Copy link
Member

rullzer commented Apr 4, 2018

Fix in #9070

@tobiasKaminsky
Copy link
Member Author

Working 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Apr 4, 2018
rullzer added a commit that referenced this issue Apr 4, 2018
@rullzer
When formatting a share node an Empty target is invalid
36bd4b7 
Fixes #9028

For federated shares the share table holds no target information (since
it is on the other server). So when a node is actually invalid and not
found we should not display it anymore in the shared with sections etc
and thus throw the proper exceptions.

Signed-off-by: Roeland Jago Douma <[email protected]>
@tobiasKaminsky tobiasKaminsky mentioned this issue Apr 4, 2018
Closed
3 tasks
panovotn pushed a commit to panovotn/server that referenced this issue Apr 18, 2018
@rullzer @panovotn
When formatting a share node an Empty target is invalid
9055864 
Fixes nextcloud#9028

For federated shares the share table holds no target information (since
it is on the other server). So when a node is actually invalid and not
found we should not display it anymore in the shared with sections etc
and thus throw the proper exceptions.

Signed-off-by: Roeland Jago Douma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature: sharing
Projects
None yet
Milestone
Nextcloud 14
Development

No branches or pull requests
3 participants
@rullzer @MorrisJobke @tobiasKaminsky