-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing: Cannot delete files from share #1708
Comments
I fail to reproduce. Does this happen for you all the time? Can you try to replace line 42 in apps/files_accesscontrol/lib/CacheWrapper.php public function __construct(ICache $cache, StorageWrapper $storage, Operation $operation) { after: public function __construct(ICache $cache, \OCP\Files\Storage\IStorage $storage, Operation $operation) { |
{
"Code": 0,
"Exception": "TypeError",
"File": "apps/files_accesscontrol/lib/CacheWrapper.php",
"Line": 42,
"Message": "Argument 2 passed to OCA\\FilesAccessControl\\CacheWrapper::__construct() must be an instance of OCA\\FilesAccessControl\\StorageWrapper, instance of OC\\Files\\Storage\\Wrapper\\PermissionsMask given, called in apps/files_accesscontrol/lib/StorageWrapper.php on line 404",
"Trace": "
#0 apps/files_accesscontrol/lib/StorageWrapper.php(404): OCA\\FilesAccessControl\\CacheWrapper->__construct(Object(OCA\\FilesAutomatedTagging\\CacheWrapper), Object(OC\\Files\\Storage\\Wrapper\\PermissionsMask), Object(OCA\\FilesAccessControl\\Operation))
#1 lib/private/Files/Storage/Wrapper/Wrapper.php(388): OCA\\FilesAccessControl\\StorageWrapper->getCache('files/Documents...', Object(OC\\Files\\Storage\\Wrapper\\PermissionsMask))
#2 lib/private/Files/Storage/Wrapper/PermissionsMask.php(130): OC\\Files\\Storage\\Wrapper\\Wrapper->getCache('files/Documents...', Object(OC\\Files\\Storage\\Wrapper\\PermissionsMask))
#3 lib/private/Files/View.php(1284): OC\\Files\\Storage\\Wrapper\\PermissionsMask->getCache('files/Documents...')
#4 lib/private/Files/View.php(1338): OC\\Files\\View->getCacheEntry(Object(OC\\Files\\Storage\\Wrapper\\PermissionsMask), 'files/Documents...', '/Documents/univ...')
#5 lib/private/Preview.php(232): OC\\Files\\View->getFileInfo('/files/Document...')
#6 lib/private/Preview.php(266): OC\\Preview->getFileInfo()
#7 lib/private/Preview.php(131): OC\\Preview->setFile('/Documents/univ...')
#8 lib/private/Preview.php(1345): OC\\Preview->__construct(false, 'files/', '/Documents/univ...')
#9 lib/private/Preview.php(1252): OC\\Preview::post_delete(Array, 'files/')
#10 lib/private/legacy/hook.php(106): OC\\Preview::post_write(Array)
#11 apps/dav/lib/Connector/Sabre/File.php(291): OC_Hook::emit('OC_Filesystem', 'post_write', Array)
#12 apps/dav/lib/Connector/Sabre/File.php(207): OCA\\DAV\\Connector\\Sabre\\File->emitPostHooks(false)
#13 apps/dav/lib/Connector/Sabre/Directory.php(137): OCA\\DAV\\Connector\\Sabre\\File->put(Resource id #459)
#14 3rdparty/sabre/dav/lib/DAV/Server.php(1036): OCA\\DAV\\Connector\\Sabre\\Directory->createFile('rotes-herz-2.jp...', Resource id #459)
#15 3rdparty/sabre/dav/lib/DAV/CorePlugin.php(523): Sabre\\DAV\\Server->createFile('rotes-herz-2.jp...', Resource id #459, NULL)
#16 [internal function]: Sabre\\DAV\\CorePlugin->httpPut(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))
#17 3rdparty/sabre/event/lib/EventEmitterTrait.php(105): call_user_func_array(Array, Array)
#18 3rdparty/sabre/dav/lib/DAV/Server.php(459): Sabre\\Event\\EventEmitter->emit('method:PUT', Array)
#19 3rdparty/sabre/dav/lib/DAV/Server.php(248): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))
#20 apps/dav/appinfo/v1/publicwebdav.php(95): Sabre\\DAV\\Server->exec()
#21 public.php(77): require_once('/var/www/html/h...')
#22 {main}
"
} @hoellen What files access control rules do you have setup? |
@MorrisJobke I don't use the file access control at the moment. No rules are defined.
|
Btw if you are not using it, disable the app. It reduces the load on each request. |
Good idea, I disabled 4 apps which I don't use. Thanks again. |
Hi, i can confirm this Problem:
owncloud log error:
If i change the line you proposed: 42 in apps/files_accesscontrol/lib/CacheWrapper.php from: i can remove the file via linkshare. There is another problem which is fixed by this change with create folders inside a link share. startServer configuration Operating system: Web server: Database: PHP version: Nextcloud version: (see Nextcloud admin page) .tar.bz2 archive from nextcloud.com website Are you using encryption: Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... Im using file access control: endp.s. I think owncloud has a similar or the same problem. Please keep us informed, if there is the final solution. |
That will be the final solution then |
Do you want to merge this? p.s. There still is the warning:
|
Steps to reproduce
Expected behaviour
User should be able to upload files and delete them.
Actual behaviour
User can upload a file, but can't delete the uploaded file. (Notification message on top: Error deleting file "test.pdf" and one error in Nextcloud log file.)
Server configuration
Operating system:
CentOS Linux release 7.2.1511 (Core)
Web server:
nginx/1.10.1
Database:
mysql Ver 15.1 Distrib 5.5.50-MariaDB
PHP version:
PHP 7.0.11
Nextcloud version: (see Nextcloud admin page)
10.0.1 (stable)
Updated from an older Nextcloud/ownCloud or fresh install:
OC 8.x -> NC 9 -> NC 9.0.52 -> NC 10 -> NC 10.0.1
Where did you install Nextcloud from:
.tar.bz2 archive from nextcloud.com website
Signing status:
List of activated apps:
App list
The content of config/config.php:
Config report
Are you using external storage, if yes which one:
Google Drive and Dropbox connection. But no file which is affected by this error is in the external storage.
Are you using encryption:
No.
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
No
Client configuration
Browser:
Firefox 49.0.1
Operating system:
Arch Linux
Logs
Web server error log
Web server error log
Nextcloud log
Browser log
After the DELETE request I get as response an "Internal Server Error - 500"
The text was updated successfully, but these errors were encountered: