Storage wrapper warnings

[MorrisJobke]

I see following two warnings in the logs:

Storage wrapper 'readonly' was not registered via the 'OC_Filesystem - preSetup' hook which could cause potential problems.
Storage wrapper 'sharePermissions' was not registered via the 'OC_Filesystem - preSetup' hook which could cause potential problems.

They are added in owncloud/core#24335

They are registered in

server/apps/files_sharing/ajax/shareinfo.php

Line 66 in 0215b00

\OC\Files\Filesystem::addStorageWrapper('readonly', function ($mountPoint, $storage) {

and

server/apps/dav/appinfo/v1/publicwebdav.php

Line 79 in 1fef5d3

\OC\Files\Filesystem::addStorageWrapper('sharePermissions', function ($mountPoint, $storage) use ($share) {

I talked with @nickvergessen about this and he proposed to change the check to

if (self::$logWarningWhenAddingStorageWrapper && $wrapperName !== 'readonly') {

@icewind1991 What do do here? Is this the correct approach or should it be done somehow differently?

[icewind1991]

Easiest solution seems to be to disable the warning with logWarningWhenAddingStorageWrapper from where the wrappers are added (with a comment describing that we know what we're doing here)

[MorrisJobke]

Easiest solution seems to be to disable the warning with logWarningWhenAddingStorageWrapper from where the wrappers are added (with a comment describing that we know what we're doing here)

Then I will do this tomorrow

[nickvergessen]

At least the one from sharePermissions seems to be a problem?
#1708

[MorrisJobke]

I added the part of the readonly part: #1722

[enoch85]

And this is one reason I just <3 Nextcloud. Things get fixed.

[enoch85]

@MorrisJobke No backport? :(