Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in the "Sharing" administrator settings #14793

Closed
Valdnet opened this issue Mar 21, 2019 · 4 comments · Fixed by #14801
Closed

Translation in the "Sharing" administrator settings #14793

Valdnet opened this issue Mar 21, 2019 · 4 comments · Fixed by #14801
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Milestone

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Mar 21, 2019

Translation in the "Sharing" administrator settings:

obraz

obraz

They are downloaded from the folder: settings\l10n instead of lib\l10n.

Or the translation should be moved to: settings\l10n.

Below is the code from the file :lib\private\Settings\Admin\Sharing.php

private function getSharePermissionList() {
		return [
			[
				'id' => 'cancreate',
				'label' => $this->l->t('Create'),
				'value' => Constants::PERMISSION_CREATE
			],
			[
				'id' => 'canupdate',
				'label' => $this->l->t('Change'),
				'value' => Constants::PERMISSION_UPDATE
			],
			[
				'id' => 'candelete',
				'label' => $this->l->t('Delete'),
				'value' => Constants::PERMISSION_DELETE
			],
			[
				'id' => 'canshare',
				'label' => $this->l->t('Share'),
				'value' => Constants::PERMISSION_SHARE
			],
		];
	}

App: Nextcloud v15.0.5

@Valdnet Valdnet added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 21, 2019
@rullzer
Copy link
Member

rullzer commented Mar 21, 2019

Ah joy. Another reason we should move those settings properly over. Let me check this.

@rullzer
Copy link
Member

rullzer commented Mar 21, 2019

mmm @Valdnet do you actually not see the translations? Because they should be in both translation files.

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 22, 2019

@rullzer the translation is in the files:
lib/l10n/pl.js
lib/l10n/pl.json

"Create" : "Utwórz",
"Change" : "Zmień",
"Delete" : "Usuń",
"Share" : "Udostępnij",

while where translations in files:
settings/l10n/pl.js
settings/l10n/pl.json

is located only
"Delete" : "Usuń",
and it belongs to the translation for another option.

There are no words in Transifex for translating in "settings-1": Create, Change and Share.

rullzer added a commit that referenced this issue Mar 22, 2019
Fixes #14793

This is caused by the mess we have with OC\Settings mapping to settings
and lib/private/Settings.

Anyway this is the quick fix. Moving stuff around for 17 seems better.

Signed-off-by: Roeland Jago Douma <[email protected]>
@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 22, 2019

See also the issue #14607.

rullzer added a commit that referenced this issue Mar 25, 2019
Fixes #14793

This is caused by the mess we have with OC\Settings mapping to settings
and lib/private/Settings.

Anyway this is the quick fix. Moving stuff around for 17 seems better.

Signed-off-by: Roeland Jago Douma <[email protected]>
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants