Skip to content

Commit

Permalink
Get correct version of an app
Browse files Browse the repository at this point in the history
Related to #8929

We should get the version of the app. Not of the appfolder. Else there
is no way to properly compare the versions.

Now note that installing in 1 go will still fail. But at least on the
next page load the new version will be properly detected.

Signed-off-by: Roeland Jago Douma <[email protected]>
  • Loading branch information
rullzer committed May 9, 2018
1 parent 44255fa commit a794806
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/private/legacy/app.php
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ public static function findAppInDirectories($appId) {
} else {
$versionToLoad = array();
foreach ($possibleApps as $possibleApp) {
$version = self::getAppVersionByPath($possibleApp['path']);
$version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
$versionToLoad = array(
'dir' => $possibleApp,
Expand Down

0 comments on commit a794806

Please sign in to comment.