fix: Support other schemes than HTTP and HTTPS in app navigation

Signed-off-by: Côme Chilliet <[email protected]>
nextcloud · Feb 1, 2024 · 5088e58 · 5088e58
1 parent ef59f72
commit 5088e58
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/Controller/NavigationController.php b/core/Controller/NavigationController.php
@@ -115,7 +115,8 @@ private function generateETag(array $navigation): string {
 	 */
 	private function rewriteToAbsoluteUrls(array $navigation): array {
 		foreach ($navigation as &$entry) {
-			if (!str_starts_with($entry['href'], 'https://') && !str_starts_with($entry['href'], 'http://')) {
+			/* If parse_url finds no host it means the URL is not absolute */
+			if (!isset(\parse_url($entry['href'])['host'])) {
 				$entry['href'] = $this->urlGenerator->getAbsoluteURL($entry['href']);
 			}
 			if (!str_starts_with($entry['icon'], $this->urlGenerator->getBaseUrl())) {