fix(QueryBuilder): Restrict identifier length to 30 characters due to…

… Oracle limitations Signed-off-by: provokateurin <[email protected]>
nextcloud · Sep 26, 2024 · 35dfc63 · 35dfc63
1 parent 9a22098
commit 35dfc63
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/lib/private/DB/QueryBuilder/QueryBuilder.php b/lib/private/DB/QueryBuilder/QueryBuilder.php
@@ -206,6 +206,23 @@ private function prepareForExecute() {
 		// }
 		// }
 
+		$tooLongOutputColumns = [];
+		foreach ($this->getOutputColumns() as $column) {
+			if (strlen($column) > 30) {
+				$tooLongOutputColumns[] = $column;
+			}
+		}
+
+		if (!empty($tooLongOutputColumns)) {
+			$exception = new QueryException('More than 30 characters for an output column name are not allowed on Oracle.');
+			$this->logger->error($exception->getMessage(), [
+				'query' => $this->getSQL(),
+				'columns' => $tooLongOutputColumns,
+				'app' => 'core',
+				'exception' => $exception,
+			]);
+		}
+
 		$numberOfParameters = 0;
 		$hasTooLargeArrayParameter = false;
 		foreach ($this->getParameters() as $parameter) {