Skip to content

Commit

Permalink
manifest to report correct favicon size
Browse files Browse the repository at this point in the history
In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image.
https://github.com/nextcloud/server/blob/d9015a8c94bfd71fe484618a06d276701d3bf9ff/apps/theming/lib/Controller/IconController.php#L146

The problem is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?)
  • Loading branch information
nhirokinet authored Oct 16, 2020
1 parent 09501e1 commit 218e57f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apps/theming/lib/Controller/ThemingController.php
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ public function getManifest($app) {
'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
['app' => $app]) . '?v=' . $cacheBusterValue,
'type' => 'image/png',
'sizes' => '128x128'
'sizes' => '512x512'
],
[
'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
Expand Down

0 comments on commit 218e57f

Please sign in to comment.