fix: Avoid 3px offset on public share links

[juliusknorr]

Avoid that the background page is shining through at the bottom of public share links

[juliusknorr]

/backport to stable28

[juliusknorr]

/backport to stable27

[jancborchardt]

@juliushaertl does this have anything to do with the color accent bar on the top at the compact view? Cause that does not show for the share link in compact view (does show for compact view when logged in).
It correctly does not show for tabbed view regardless of log in status.

[juliusknorr]

@juliushaertl does this have anything to do with the color accent bar on the top at the compact view? Cause that does not show for the share link in compact view (does show for compact view when logged in).

Before this patch the accent bar in compact mode was hidden due to this offset.

Now with this patch the behaviour is the following (which I think is the expected):

• Compact mode shows accent bar
• Tabbed mode shows no accent bar

[pedropintosilva]

Thanks @juliushaertl I'm a bit afraid of this. By he looks of it, it seems will affect the component height and position no matter if it's share link or not (unless that is only used in those cases). I also would like to understand why we had before the additional calculation in the height and the top position. I wonder if it was fixing some sizing thingy and I', afraid it can become regression for some devices.

Here is what I have found out

• It seems that height was introduced with Fix scrolling behaviour on Nextcloud >= 14 907708f
• The additional 3px (height) and the -3px (top) were added to Improve loading state handling c9cb1bd

[pedropintosilva]

my conclusion: good to merge but we need to make sure if doesn't get backported to a version where it will brake other things