Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make rename update the file list properly on files2vue #3345

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 7, 2023

Summary

@eszkadev I've wondered a bit why the post message content would actually be url encoded, I don't think there is a real need, on the other hand it is proably easier adjusting here then in online which could be considered a breaking change.

Also the File_Rename post message does not seem to be documented at https://sdk.collaboraonline.com/docs/postmessage_api.html

@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Dec 7, 2023
@juliusknorr
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a file after rename in COOL doesn't work
2 participants