Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collabora Online broken in Nextcloud14 #237

Closed
schiessle opened this issue Aug 13, 2018 · 5 comments
Closed

Collabora Online broken in Nextcloud14 #237

schiessle opened this issue Aug 13, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@schiessle
Copy link
Member

Collabora Online broken with Nextcloud 14 beta3 on public pages

image

probably related to some template changes we did for Nextcloud 14: nextcloud/server#9982

cc @skjnldsv

@schiessle schiessle added the bug Something isn't working label Aug 13, 2018
@skjnldsv
Copy link
Member

@schiessle the bottom padding?

@schiessle
Copy link
Member Author

@skjnldsv bottom padding and the icon bar at the top is missing

@skjnldsv
Copy link
Member

For the icons, this is coming from the iframe, so I'm really not sure this is related to the layout update.
Also, the toolbar is hidden because the file is in readonly:

#toolbar-wrapper.readonly {
	display: none;
}

For the padding: nextcloud/server#10641

@rullzer
Copy link
Member

rullzer commented Aug 15, 2018

Missing toolbar seems to indeed be just ebcause the document was read-only ;)

Other stuff fixed in server with nextcloud/server#10691

@rullzer rullzer closed this as completed Aug 15, 2018
@schiessle
Copy link
Member Author

@rullzer right, the toolbar is back if I add write permissions. But I noticed something else which again is more likely because of our layout changes:

image

I assume that this looked nicer on Nextcloud 13 😉

@schiessle schiessle reopened this Aug 15, 2018
rullzer added a commit that referenced this issue Aug 17, 2018
Fixes #237
Else it looks rather out of place

Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer added a commit that referenced this issue Aug 17, 2018
Fixes #237
Else it looks rather out of place

Signed-off-by: Roeland Jago Douma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants