Add admin page for polls

appinfo/info.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
-<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
-      xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
+<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
     <id>polls</id>
     <name>Polls</name>
     <summary>A polls app, similar to doodle/dudle with the possibility to restrict access.</summary>
@@ -26,24 +25,30 @@
         <php min-version="7.3"/>
         <nextcloud min-version="21" max-version="22" />
     </dependencies>
-	<background-jobs>
-		<job>OCA\Polls\Cron\NotificationCron</job>
+    <background-jobs>
+        <job>OCA\Polls\Cron\NotificationCron</job>
         <job>OCA\Polls\Cron\JanitorCron</job>
-	</background-jobs>
-	<commands>
-		<command>OCA\Polls\Command\Share\Add</command>
-		<command>OCA\Polls\Command\Share\Remove</command>
-	</commands>
-	<repair-steps>
-		<pre-migration>
-			<step>OCA\Polls\Migration\RemoveIndices</step>
-			<step>OCA\Polls\Migration\DeleteInvalidRecords</step>
+    </background-jobs>
+    <commands>
+        <command>OCA\Polls\Command\Share\Add</command>
+        <command>OCA\Polls\Command\Share\Remove</command>
+    </commands>
+    <settings>
+        <admin-section>OCA\Polls\Settings\AdminSection</admin-section>
+        <personal-section>OCA\Polls\Settings\PersonalSection</personal-section>
+        <admin>OCA\Polls\Settings\AdminSettings</admin>
+        <personal>OCA\Polls\Settings\PersonalSettings</personal>
+    </settings>
+    <repair-steps>
+        <pre-migration>
+            <step>OCA\Polls\Migration\RemoveIndices</step>
+            <step>OCA\Polls\Migration\DeleteInvalidRecords</step>
         </pre-migration>
-		<post-migration>
-			<step>OCA\Polls\Migration\CreateIndices</step>
+        <post-migration>
+            <step>OCA\Polls\Migration\CreateIndices</step>
         </post-migration>
     </repair-steps>
-	<navigations>
+    <navigations>
         <navigation>
             <name>Polls</name>
             <route>polls.page.index</route>

appinfo/routes.php

@@ -87,6 +87,9 @@
 		['name' => 'share#sendInvitation', 'url' => '/share/{token}/invite', 'verb' => 'POST'],
 		['name' => 'share#resolveGroup', 'url' => '/share/{token}/resolve', 'verb' => 'GET'],
 
+		['name' => 'settings#getAppSettings', 'url' => '/settings/app', 'verb' => 'GET'],
+		['name' => 'settings#writeAppSettings', 'url' => '/settings/app', 'verb' => 'POST'],
+
 		['name' => 'subscription#get', 'url' => '/poll/{pollId}/subscription', 'verb' => 'GET'],
 		['name' => 'subscription#set', 'url' => '/poll/{pollId}/subscription', 'verb' => 'PUT'],
 		['name' => 'subscription#subscribe', 'url' => '/poll/{pollId}/subscribe', 'verb' => 'PUT'],
@@ -97,11 +100,13 @@
 		['name' => 'comment#delete', 'url' => '/comment/{commentId}', 'verb' => 'DELETE', 'postfix' => 'auth'],
 
 		['name' => 'system#user_search', 'url' => '/search/users/{query}', 'verb' => 'GET'],
-		['name' => 'watch#watch_poll', 'url' => '/poll/{pollId}/watch', 'verb' => 'GET'],
+		['name' => 'system#group_search', 'url' => '/groups/{query}', 'verb' => 'GET', 'postfix' => 'query'],
+		['name' => 'system#group_search', 'url' => '/groups', 'verb' => 'GET', 'postfix' => 'all'],
 
-		['name' => 'preferences#write', 'url' => '/preferences/write', 'verb' => 'POST'],
-		['name' => 'preferences#get', 'url' => '/preferences/get', 'verb' => 'GET'],
+		['name' => 'watch#watch_poll', 'url' => '/poll/{pollId}/watch', 'verb' => 'GET'],
 
+		['name' => 'preferences#write', 'url' => '/preferences', 'verb' => 'POST'],
+		['name' => 'preferences#get', 'url' => '/preferences', 'verb' => 'GET'],
 		['name' => 'preferences#get_calendars', 'url' => '/calendars', 'verb' => 'GET'],
 
 		// REST-API calls

lib/Controller/PollController.php

@@ -31,6 +31,7 @@
 use OCA\Polls\Service\PollService;
 use OCA\Polls\Service\OptionService;
 use OCA\Polls\Model\Acl;
+use OCA\Polls\Model\AppSettings;
 
 class PollController extends Controller {
 
@@ -70,7 +71,12 @@ public function __construct(
 
 	public function list(): DataResponse {
 		return $this->response(function () {
-			return $this->pollService->list();
+			// return $this->pollService->list();
+			$appSettings = new AppSettings;
+			return [
+				'list' => $this->pollService->list(),
+				'pollCreationAllowed' => $appSettings->getCreationAllowed(),
+			];
 		});
 	}
 

lib/Controller/SettingsController.php

@@ -0,0 +1,66 @@
+<?php
+/**
+ * @copyright Copyright (c) 2017 Vinzenz Rosenkranz <[email protected]>
+ *
+ * @author René Gieling <[email protected]>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ *  This program is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU Affero General Public License as
+ *  published by the Free Software Foundation, either version 3 of the
+ *  License, or (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU Affero General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Affero General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Polls\Controller;
+
+use OCP\IRequest;
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http\DataResponse;
+use OCA\Polls\Service\SettingsService;
+
+class SettingsController extends Controller {
+
+	/** @var SettingsService */
+	private $settingsService;
+
+	use ResponseHandle;
+
+	public function __construct(
+		string $appName,
+		IRequest $request,
+		SettingsService $settingsService
+	) {
+		parent::__construct($appName, $request);
+		$this->settingsService = $settingsService;
+	}
+
+	/**
+	 * Read app settings
+	 * @NoAdminRequired
+	 */
+	public function getAppSettings(): DataResponse {
+		return $this->response(function (): array {
+			return ['appSettings' => $this->settingsService->getAppSettings()];
+		});
+	}
+
+	/**
+	 * Write app settings
+	 */
+	public function writeAppSettings(array $appSettings): DataResponse {
+		$this->settingsService->writeAppSettings($appSettings);
+		return $this->response(function (): array {
+			return ['appSettings' => $this->settingsService->getAppSettings()];
+		});
+	}
+}

lib/Controller/SystemController.php

@@ -47,10 +47,23 @@ public function __construct(
 	/**
 	 * Get a combined list of NC users, groups and contacts
 	 * @NoAdminRequired
-	 * $query
 	 */
 	public function userSearch(string $query = ''): DataResponse {
 		return new DataResponse(['siteusers' => $this->systemService->getSiteUsersAndGroups(
 			$query)], Http::STATUS_OK);
 	}
+	/**
+	 * Get a combined list of NC groups
+	 */
+	public function groupAll(): DataResponse {
+		return new DataResponse(['groups' => $this->systemService->getGroups()], Http::STATUS_OK);
+	}
+
+	/**
+	 * Get a combined list of NC groups
+	 */
+	public function groupSearch(string $query = ''): DataResponse {
+		return new DataResponse(['groups' => $this->systemService->getGroups(
+			$query)], Http::STATUS_OK);
+	}
 }

lib/Exceptions/InvalidUsernameException.php

@@ -28,7 +28,6 @@
 class InvalidUsernameException extends Exception {
 	/**
 	 * InvalidUsernameException Constructor
-	 * @param string $e exception message
 	 */
 	public function __construct(string $e = 'Username not allowed') {
 		parent::__construct($e, Http::STATUS_FORBIDDEN);

lib/Migration/Version030000Date20210704120000.php

@@ -75,7 +75,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
 		TableSchema::createOrUpdateSchema($schema, $output);
 		// remove old migration entries from versions prior to polls 3.x
 		// including migration versions from test releases
-		// theoretically, only this migration should be existen. If not, no matter
+		// theoretically, only this migration should be existent. If not, no matter
 		TableSchema::removeObsoleteMigrations($this->connection, $output);
 
 		$this->fixVotes->run($output);

lib/Model/Acl.php

@@ -54,10 +54,15 @@ class Acl implements JsonSerializable {
 	public const PERMISSION_COMMENT_ADD = 'comment';
 	public const PERMISSION_OPTIONS_ADD = 'add_options';
 	public const PERMISSION_VOTE_EDIT = 'vote';
+	public const PERMISSION_PUBLIC_SHARES = 'publicShares';
+	public const PERMISSION_ALL_ACCESS = 'allAccess';
 
 	/** @var IUserManager */
 	private $userManager;
 
+	/** @var AppSettings */
+	private $appSettings;
+
 	/** @var IGroupManager */
 	private $groupManager;
 
@@ -90,6 +95,7 @@ public function __construct(
 		$this->shareMapper = $shareMapper;
 		$this->poll = new Poll;
 		$this->share = new Share;
+		$this->appSettings = new AppSettings;
 	}
 
 
@@ -220,6 +226,11 @@ public function getIsAllowed(string $permission): bool {
 			case self::PERMISSION_VOTE_EDIT:
 				return !$this->poll->getExpired() && $this->share->getType() !== Share::TYPE_PUBLIC;
 
+			case self::PERMISSION_ALL_ACCESS:
+				return $this->appSettings->getAllAccessAllowed();
+
+			case self::PERMISSION_PUBLIC_SHARES:
+				return $this->appSettings->getPublicSharesAllowed();
 		}
 
 		return false;
@@ -234,10 +245,12 @@ public function request(string $permission): void {
 	public function jsonSerialize(): array {
 		return	[
 			'allowAddOptions' => $this->getIsAllowed(self::PERMISSION_OPTIONS_ADD),
+			'allowAllAccess' => $this->getIsAllowed(self::PERMISSION_ALL_ACCESS),
 			'allowArchive' => $this->getIsAllowed(self::PERMISSION_POLL_ARCHIVE),
 			'allowComment' => $this->getIsAllowed(self::PERMISSION_COMMENT_ADD),
 			'allowDelete' => $this->getIsAllowed(self::PERMISSION_POLL_DELETE),
 			'allowEdit' => $this->getIsAllowed(self::PERMISSION_POLL_EDIT),
+			'allowPublicShares' => $this->getIsAllowed(self::PERMISSION_PUBLIC_SHARES),
 			'allowSeeResults' => $this->getIsAllowed(self::PERMISSION_POLL_RESULTS_VIEW),
 			'allowSeeUsernames' => $this->getIsAllowed(self::PERMISSION_POLL_USERNAMES_VIEW),
 			'allowSubscribe' => $this->getIsAllowed(self::PERMISSION_POLL_SUBSCRIBE),