add setting for view mode #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korelstar
added
the
feature: editor
|
Nice :) Honest question: Should this be synvhronized by clients? Keeping the state in sync seems to be a valid goal, but the requirements might be different on a mobile device... 🤔 |
|
I thought about that, too. This is why I used exactly the same string labels for the setting and setting options like in your Android app. With this PR, the new setting will be provided through the (settings) API. Hence, clients can use this setting for their GUI, too. But it's up to the client developer, how this setting should exactly be used in the client app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting "Display mode for notes" with options "Open in edit mode" and "Open in preview mode". If you open a note, it will be shown either in edit mode or in preview mode - depending on this setting. In both cases, you can still change the mode by using the action "Preview" resp. "Edit" in the three-dots-menu in the upper-right corner.
Fixes #352.