Remove non-functional unread and starred filter and code cleaning #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
approved these changes
Nov 19, 2024
These filters are redundat to the unread and starred route. They only filter already loaded items and didn't will work as expected, because they could initially hide items or prevent the scroll from loading additional items from the backend, depending the user settings. Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
wofferl
force-pushed
the
code_cleaning
branch
from
a7ff592 to
3fdc9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2847
Summary
These filters are redundant to the unread and starred route, but they only filter already loaded items and didn't will work as expected, because they could initially hide items or prevent the scroll from loading additional items from the backend, depending the user settings.
For an app that has only a small part of all items loaded, this type of filter cannot work.
Checklist