Performance improvements and ordering rework #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual filterSortedItems() is called multiple times through different events where it is not necessary (mark read, starred) and it is called extra every time using key navigation. Signed-off-by: Wolfgang <[email protected]>
* prevent first items api call using incorrect ordering * use out of scope filter also in feed view * refresh itemlist and show correct items when changing feed or global sort order Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
3 tasks
SMillerDev
approved these changes
Oct 29, 2024
…ed in the item list This is a follow up fix for the change to the filtered sorted item list Signed-off-by: Wolfgang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jshortcut doesn't load more items in infinite scroll #2847Summary
This PR changes the way when the sorted item list is updated, to prevent sorting the whole list for every click or twice for changing to next item when navigating with keyboard.
Also the item list now shows the correct items immediately after changing, the feed or global sort order.
Checklist