Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend refresh features #2844

Merged
merged 22 commits into from
Nov 7, 2024
Merged

Add frontend refresh features #2844

merged 22 commits into from
Nov 7, 2024

Conversation

wofferl
Copy link
Collaborator

@wofferl wofferl commented Oct 24, 2024

Summary

Because these features need a bit of testing, I'm doing this as a draft.

This pull request adds

  • refresh pressing 'r'
  • automatic refresh every 60 seconds (can be disabled in user settings)
  • automatic refresh events if new items are detected (oldest->newest route)
  • automatic refresh when switching feed and new items are loaded
  • feed/folder navigation with 'd', 'f', 'c' and 'v'
  • show when feeds have errors

This PR also fixes some problems that appeared during testing.

  • better handling of the sidebar folder/feed list
  • fix for mark read feed/folder
  • items not displayed when changing routes or settings

Checklist

@wofferl wofferl marked this pull request as ready for review November 1, 2024 19:59
@wofferl wofferl changed the title WIP frontend refresh features add frontend refresh features Nov 1, 2024
@wofferl wofferl changed the title add frontend refresh features Add frontend refresh features Nov 1, 2024
@SMillerDev
Copy link
Contributor

@wofferl Nice work here. If you want you can contact @jancborchardt to be added to the Nextcloud Talk for this app for easier communication about the 25.x release.

@wofferl
Copy link
Collaborator Author

wofferl commented Nov 2, 2024

@wofferl Nice work here. If you want you can contact @jancborchardt to be added to the Nextcloud Talk for this app for easier communication about the 25.x release.

@SMillerDev
Not sure about that, sounds like more work. ;)
What would be the best way to contact him?

@devlinjunker
Copy link
Contributor

devlinjunker commented Nov 2, 2024 via email

@jancborchardt
Copy link
Member

@wofferl I can simply invite you with the email that you use for your commits if that’s ok? :) If you prefer I use a different email, you can contact me at "my first name at nextcloud dot com".

@wofferl
Copy link
Collaborator Author

wofferl commented Nov 4, 2024

@jancborchardt thanks, I have sent you an e-mail.

* read newestItemId when possible from api responses and fetch feed data when it differs
* fetch feed data if the fetched item ids are higher then newestItemId
* optimize FETCH and SET functions so that it can be used for future features like manual or timed refresh

Signed-off-by: Wolfgang <[email protected]>
…e from fetch items to trigger syncing feeds

Signed-off-by: Wolfgang <[email protected]>
…av array, also don't hide the actual active feed/folder

Signed-off-by: Wolfgang <[email protected]>
@Grotax Grotax enabled auto-merge (rebase) November 7, 2024 09:19
@Grotax Grotax merged commit 1b6b7e0 into nextcloud:master Nov 7, 2024
23 of 24 checks passed
@woffer
Copy link

woffer commented Nov 7, 2024 via email

@ace02000
Copy link

ace02000 commented Nov 8, 2024

great, thank you @wofferl

@wofferl wofferl deleted the reload_items branch November 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unread Counter becomes negative
7 participants