Resolve relative URLs during feed discovery #1631
Closed
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a feed is added using the feed discovery feature, and the feed link uses a relative URL, the discovery needs to resolve the URL relative to the provided website URL. Fixes nextcloud#1385 Signed-off-by: Mormegil <[email protected]>
mormegil-cz
force-pushed
the
bugfix/relative-url-discovery
branch
from
dcfa089 to
6eba9d0
Compare
|
I think this is better fixed in feedio, the library we use here. Can you try and make a pull request there? |
|
I was thinking the other day that we maybe should change the order. First check if the entered url is a valid feed with feed-io. And the relative urls, I think it would be nicer if feed-io would manage that. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Solved here: alexdebril/feed-io#422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feed is added using the feed discovery feature, and the feed link
uses a relative URL, the discovery needs to resolve the URL relative
to the provided website URL.
Fixes #1385