Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PEAR Horde packages to Bytestream packages #6317

Merged
merged 1 commit into from
May 12, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 27, 2022

Fixes #5136

Once the Horde packages are migrated to packagist we can jump back to the "original". Let's send patches to both versions for now.

To do

@ChristophWurst ChristophWurst added this to the v1.13.0 milestone Apr 27, 2022
@ChristophWurst ChristophWurst self-assigned this Apr 27, 2022
@ChristophWurst
Copy link
Member Author

@bytestream thanks a lot for your packages. The migration experience was super smooth. I'll send patches for the deprecation notices soon ✌️

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works so far. When can we release/merge this? Did NC drop PHP 7.3 already?

@ChristophWurst
Copy link
Member Author

Did NC drop PHP 7.3 already?

Only with Nextcloud 24+

@bytestream
Copy link

For what it's worth, I don't think I actually introduced any PHP 7.4 specific code. You could send PR to https://packagist.org/?query=bytestream%20horde which loosens the PHP requirement to ^7.3 || ^8.0 and updates the GitHub workflow

@ChristophWurst ChristophWurst force-pushed the techdept/pear-to-bytestream branch from 1bb40b6 to 4447c9e Compare May 12, 2022 11:38
@ChristophWurst ChristophWurst marked this pull request as ready for review May 12, 2022 11:38
@ChristophWurst ChristophWurst requested a review from kesselb May 12, 2022 11:38
@ChristophWurst ChristophWurst merged commit b4d7723 into main May 12, 2022
@ChristophWurst ChristophWurst deleted the techdept/pear-to-bytestream branch May 12, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Migrate from composer v1 to composer v2
3 participants