Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bg job for label sync #5010

Merged
merged 1 commit into from
May 26, 2021
Merged

Add bg job for label sync #5010

merged 1 commit into from
May 26, 2021

Conversation

miaulalala
Copy link
Contributor

Fixes some tasks for #25

@miaulalala miaulalala added this to the v1.10.0 milestone May 6, 2021
@miaulalala miaulalala self-assigned this May 6, 2021
@miaulalala miaulalala marked this pull request as ready for review May 10, 2021 11:10
kesselb
kesselb approved these changes May 11, 2021
View reviewed changes
ChristophWurst
ChristophWurst approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a check for whether the IMAP server supports user defined flags before we search or store them?

@miaulalala
Copy link
Contributor Author

Don't we need a check for whether the IMAP server supports user defined flags before we search or store them?

The job does that. Line 94ff.

@miaulalala miaulalala force-pushed the enhancement/migrate-important-to-label1 branch 2 times, most recently from eacf09b to 9493fa8 Compare May 25, 2021 14:28
@miaulalala
Add bg job for label sync
540ca4b 
Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala force-pushed the enhancement/migrate-important-to-label1 branch from a98f978 to 540ca4b Compare May 26, 2021 13:38
@ChristophWurst ChristophWurst merged commit 5137462 into master May 26, 2021
@ChristophWurst ChristophWurst deleted the enhancement/migrate-important-to-label1 branch May 26, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@StCyr StCyr Awaiting requested review from StCyr

Assignees

@miaulalala miaulalala

Labels
3. to review enhancement
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@miaulalala @ChristophWurst @kesselb