Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dashboard panel #3388

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Implement dashboard panel #3388

merged 1 commit into from
Aug 10, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 24, 2020 •
edited
Loading

Empty List
image image

@welcome
Copy link

welcome bot commented Jul 24, 2020

Thanks for opening your first pull request in this repository! ✌️

@rullzer rullzer mentioned this pull request Jul 24, 2020
Closed
@juliusknorr juliusknorr marked this pull request as ready for review August 6, 2020 14:31
@juliusknorr
Copy link
Member Author

Ready for review and testing

@jancborchardt
Copy link
Member

I’m seeing this for the status icons – even though I have nextcloud-vue-dashboard linked:
image

And just cause we have that on the panel integrations like GitHub etc – would be really nice to have an action menu there with direct actions for "Reply", "Mark not important" and "Delete". :)

@juliusknorr
Copy link
Member Author

I’m seeing this for the status icons – even though I have nextcloud-vue-dashboard linked:

Did you pull the recent changes of the lib?

And just cause we have that on the panel integrations like GitHub etc – would be really nice to have an action menu there with direct actions for "Reply", "Mark not important" and "Delete". :)

Let's do small steps here. I'm not too familiar with the mail app code so I'd love look into this once @ChristophWurst and @GretaD are back 😉

julien-nc
julien-nc requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@juliusknorr
Copy link
Member Author

Ready for review. Latest library is also used now so no need for npm link anymore.

ChristophWurst
ChristophWurst requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for looking into this

@juliusknorr @ChristophWurst
Implement dashboard panel
e7ab9f2 
Signed-off-by: Julius Härtl <[email protected]>
@ChristophWurst ChristophWurst merged commit acdf45f into master Aug 10, 2020
@ChristophWurst ChristophWurst deleted the enh/dashboard branch August 10, 2020 16:42
@jakobroehrl
Copy link

For me, it would be nice to show new mails, too.
What are you thinking?

@ChristophWurst
Copy link
Member

Let's discuss at https://help.nextcloud.com/c/apps/mail/35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@julien-nc julien-nc julien-nc requested changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
4. to release enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @jancborchardt @jakobroehrl @ChristophWurst @julien-nc