#3169 fix ssl client certificate (#3223)

* fix: set NCLogin as NCNetworking certificate delegate Signed-off-by: Patrick Fischer <[email protected]> * fix: ensure UIAlertControllers are presented on main thread Signed-off-by: Patrick Fischer <[email protected]> * fix: cancel authentication challenge instead of default action Signed-off-by: Patrick Fischer <[email protected]> --------- Signed-off-by: Patrick Fischer <[email protected]>
nextcloud · Jan 30, 2025 · a8fd9c9 · a8fd9c9
1 parent 1196c6b
commit a8fd9c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/iOSClient/Login/NCLogin.swift b/iOSClient/Login/NCLogin.swift
@@ -191,6 +191,8 @@ class NCLogin: UIViewController, UITextFieldDelegate, NCLoginQRCodeDelegate {
                 return outgoing
             }
         }
+
+        NCNetworking.shared.certificateDelegate = self
     }
 
     override func viewDidAppear(_ animated: Bool) {
@@ -493,7 +495,9 @@ extension NCLogin: ClientCertificateDelegate, UIDocumentPickerDelegate {
             documentProviderMenu.delegate = self
             self.present(documentProviderMenu, animated: true, completion: nil)
         }))
-        present(alertNoCertFound, animated: true)
+        DispatchQueue.main.async {
+            self.present(alertNoCertFound, animated: true)
+        }
     }
 
     func documentPicker(_ controller: UIDocumentPickerViewController, didPickDocumentsAt urls: [URL]) {
@@ -507,15 +511,19 @@ extension NCLogin: ClientCertificateDelegate, UIDocumentPickerDelegate {
         alertEnterPassword.addTextField { textField in
             textField.isSecureTextEntry = true
         }
-        present(alertEnterPassword, animated: true)
+        DispatchQueue.main.async {
+            self.present(alertEnterPassword, animated: true)
+        }
     }
 
     func onIncorrectPassword() {
         NCNetworking.shared.p12Data = nil
         NCNetworking.shared.p12Password = nil
         let alertWrongPassword = UIAlertController(title: NSLocalizedString("_client_cert_wrong_password_", comment: ""), message: "", preferredStyle: .alert)
         alertWrongPassword.addAction(UIAlertAction(title: NSLocalizedString("_ok_", comment: ""), style: .default))
-        present(alertWrongPassword, animated: true)
+        DispatchQueue.main.async {
+            self.present(alertWrongPassword, animated: true)
+        }
     }
 
     func poll(loginFlowV2Token: String, loginFlowV2Endpoint: String, loginFlowV2Login: String) {

diff --git a/iOSClient/Networking/NCNetworking.swift b/iOSClient/Networking/NCNetworking.swift
@@ -147,7 +147,7 @@ class NCNetworking: NSObject, NextcloudKitDelegate {
                 completionHandler(URLSession.AuthChallengeDisposition.useCredential, creds)
             } else {
                 self.certificateDelegate?.didAskForClientCertificate()
-                completionHandler(URLSession.AuthChallengeDisposition.performDefaultHandling, nil)
+                completionHandler(URLSession.AuthChallengeDisposition.cancelAuthenticationChallenge, nil)
             }
         } else {
             self.checkTrustedChallenge(session, didReceive: challenge, completionHandler: completionHandler)