This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Quick fix for new files OperationProgressbar #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
45 tasks
|
@MorrisJobke @rullzer Would be good to have this in beta1, otherwise the gallery app is broken. |
Signed-off-by: Julius Härtl <[email protected]>
|
Hm seems the merged javascript has a weired race condition, it works in debug mode and when loading the merged file from the browser cache, but not on hard reload. |
juliusknorr
added
2. developing
skjnldsv
approved these changes
Mar 5, 2019
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/fix-upload
branch
from
119ceef to
976f13d
Compare
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new OperationProgressbar the gallery app was not loading properly as the required scripts from the files app were missing.
I'm not to happy with all the files app dependencies in here, but this at least brings the gallery app back to being functional.