Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photophere not loading automatically in NC26 #121

Closed
SubhashBose opened this issue Jun 9, 2023 · 6 comments · Fixed by #122
Closed

Photophere not loading automatically in NC26 #121

SubhashBose opened this issue Jun 9, 2023 · 6 comments · Fixed by #122
Assignees
Labels
bug Something isn't working

Comments

@SubhashBose
Copy link

Until the previous Nextcloud version 25, when I click on a photosphere image (360 panorama) file, it got automatically detected and loaded in Photosphere app. Now after updating to Nextcloud version 26, and app version 1.26.3, I see that photosphere files are loaded like ordinary photos. I have to right-click on an image click "View in PhotosphereViewer" to load into the app.

Is there any setting I am missing of this is an incompatibility /bug for the new version of NC.

@R0Wi
Copy link
Member

R0Wi commented Jun 9, 2023

This is indeed not the intended behaviour. Thanks for reporting, will have a look into this

@R0Wi R0Wi added the bug Something isn't working label Jun 9, 2023
@R0Wi R0Wi self-assigned this Jun 9, 2023
@SubhashBose
Copy link
Author

Thanks for checking this. Just wanted to add some more information

My exact Nextcloud version is 26.0.2 (Nextcloud AIO docker, latest)

I also found that if I open a photosphere file from a public shared link, then Photosphere app loads automatically as intended.

R0Wi added a commit that referenced this issue Jun 9, 2023
@R0Wi R0Wi linked a pull request Jun 9, 2023 that will close this issue
@R0Wi R0Wi closed this as completed in #122 Jun 9, 2023
R0Wi added a commit that referenced this issue Jun 9, 2023
R0Wi added a commit that referenced this issue Jun 9, 2023
R0Wi added a commit that referenced this issue Jun 9, 2023
@R0Wi
Copy link
Member

R0Wi commented Jun 9, 2023

Should be fixed in app version v1.26.4. Much appreaciate your feedback!

@SubhashBose
Copy link
Author

Thank you for fixing this so quickly. I updated the app and now it works.

@SubhashBose
Copy link
Author

By the way, If I recall correctly, in older versions of the app there used to have a autorotate button in the navbar, like this one
https://jsfiddle.net/Lo6cz9py/3/

Has the autorotate button been removed in newer versions?

@R0Wi
Copy link
Member

R0Wi commented Jun 10, 2023

Think that was a side-effect of updating the PhotoSphereViewer component to v5. Currently we're starting the component in a kind of "default" configuration:

// plugins: [

I think we might need to add the AutorotatePlugin here like shown in your jsfiddle snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants