Bugfix/do not warn about invalid files in not synced folders #7977
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
requested changes
Mar 7, 2025
we currently notify invalid file names for files that the sync engine will not upload because they are ignored for other reasons (selective sync for example) let's first check if the file is ignored and only if the file would be uploaded, we can check the file name validity Signed-off-by: Matthieu Gallien <[email protected]>
if a file name is invalid, the files will be ignored if a file is excluded because of selective sync, the file will be ignored if a file is ignored for those both reasons, avoid showing a very visible warning to the user will limit too many warnings and notifications being shown Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/doNotWarnAboutInvalidFilesInNotSyncedFolders
branch
from
b37baf4 to
6234375
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7977.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
claucambra
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.