Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always set a user if we got asked for one #7974

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

nilsding
Copy link
Member

@nilsding nilsding commented Mar 6, 2025

No description provided.

@nilsding nilsding added this to the 3.16.0 milestone Mar 6, 2025
@nilsding nilsding requested a review from mgallien March 6, 2025 08:19
@nilsding nilsding self-assigned this Mar 6, 2025
@nilsding
Copy link
Member Author

nilsding commented Mar 6, 2025

/backport to stable-3.16

@mgallien mgallien force-pushed the bugfix/always-set-a-user branch from ad9f8d0 to 35eeea8 Compare March 6, 2025 08:32
@mgallien mgallien merged commit 04ba106 into master Mar 6, 2025
8 of 14 checks passed
@mgallien mgallien deleted the bugfix/always-set-a-user branch March 6, 2025 08:32
Copy link

github-actions bot commented Mar 6, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7974.zip

SHA256 checksum: bc03ee8bb261fbf1a319cc2038e1ce1453e23d41422f8c4827673e7dc7a5cdb5

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Mar 6, 2025

@mid1221213
Copy link

Hello,

I have a problem with this PR: it breaks "basic auth" login method for the desktop client. The reason is there: the reply->abort() in this very PR makes the reply->error() become QNetworkReply::OperationCanceledError instead of QNetworkReply::AuthenticationRequiredError, thus setting _resultGet = LoginFlowV2 instead of _resultGet = Basic.

I chose not to open an issue because I'm not sure the authType Basic is supposed to be still supported, but as it is in the code I guess yes. I can open an issue if you mind.

FWIW, my use case is a "special" server setup that needs, for now, HTTP Auth method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants