gui/macOS: Remove "advanced settings" section for macOS VFS settings #7928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
added
os: 🍎 macOS
feature: 💽 virtual filesystem
feature: ☁️ GUI
camilasan
approved these changes
Mar 3, 2025
camilasan
force-pushed
the
work/no-advanced-settings-mac-vfs
branch
from
85c3477 to
324121b
Compare
|
nilsding
requested changes
Mar 3, 2025
| text: qsTr("Request sync") | ||
| visible: !root.syncStatus.syncing | ||
| hoverEnabled: true | ||
| onClicked: root.controller.signalFileProviderDomain(root.accountUserIdAtHost) |
There was a problem hiding this comment.
I think you meant to emit the domainSignalRequested signal here
Signed-off-by: Claudio Cambra <[email protected]>
… component Signed-off-by: Claudio Cambra <[email protected]>
…le Provider settings Signed-off-by: Claudio Cambra <[email protected]>
… tooltip in request sync button Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
work/no-advanced-settings-mac-vfs
branch
from
324121b to
e7fcb91
Compare
|
/backport to stable-3.16 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-7928.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary. Space can be saved by simplifying the text for the button and moving it alongside the sync status item
After changes: