Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct qml style on Windows #7812

Merged
merged 1 commit into from
Jan 31, 2025
Merged

use correct qml style on Windows #7812

merged 1 commit into from
Jan 31, 2025

Conversation

nilsding
Copy link
Member

No description provided.

@nilsding nilsding added this to the 3.16.0 milestone Jan 31, 2025
@nilsding nilsding self-assigned this Jan 31, 2025
src/gui/main.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

src/gui/main.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than needing to squash the fixup commit LGTM

@mgallien mgallien enabled auto-merge January 31, 2025 14:10
@mgallien mgallien force-pushed the bugfix/fluent-style branch from f69cd67 to 438391d Compare January 31, 2025 14:11
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7812.zip

SHA256 checksum: be0a87af3360002f65f6ce178b29460bcf4833ecda3aa90a87c88d86ca8129e2

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit c151888 into master Jan 31, 2025
13 of 16 checks passed
@mgallien mgallien deleted the bugfix/fluent-style branch January 31, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants