Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the parent folder read/write always when downloading a new file #7808

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mgallien
Copy link
Collaborator

that would also cover code paths for virtual files

@mgallien mgallien added this to the 3.16.0 milestone Jan 30, 2025
@mgallien mgallien requested a review from camilasan January 30, 2025 13:57
@camilasan
Copy link
Member

With the CFAPI it seems that we don't have to change permissions before creating a placeholder file because of FsMetadata: https://learn.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants

We always use FILE_ATTRIBUTE_NORMAL which I believe allows us to create the placeholder even in a read only folder:
cloudEntry.FsMetadata.BasicInfo.FileAttributes = FILE_ATTRIBUTE_NORMAL;

@camilasan camilasan force-pushed the bugfix/betterHandlingOfReadOnlyFolders branch from 6eb55f1 to 8d19bdc Compare February 4, 2025 13:57
@mgallien mgallien force-pushed the bugfix/betterHandlingOfReadOnlyFolders branch from 8d19bdc to f1dd5a3 Compare February 6, 2025 11:23
@mgallien mgallien enabled auto-merge February 6, 2025 11:23
that would also cover code paths for virtual files

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/betterHandlingOfReadOnlyFolders branch from f1dd5a3 to c141fe9 Compare February 7, 2025 09:35
Copy link

github-actions bot commented Feb 7, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7808.zip

SHA256 checksum: f0511c8bda654c1be5752fd564a745e52c10b4bcc81567252c91015bd4f71ce3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
16 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 1a2e295 into master Feb 7, 2025
13 of 16 checks passed
@mgallien mgallien deleted the bugfix/betterHandlingOfReadOnlyFolders branch February 7, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants