Disable sync of symlinks cause they need a lot of work.

TODO

@@ -0,0 +1,6 @@
+* Add support to synchronize symbolic links
+  - This needs a lot of work cause we have to check the symlink
+    + Determine if a symlink points outside the current directory tree. They
+      are unsafe to sync.
+    + Null symlinks and absolute symlinks are always unsafe.
+  - Check which is the best way to sync symlinks

config/csync.conf

@@ -5,3 +5,7 @@ max_time_difference = 10
 
 # max directory depth recursion
 max_depth = 50
+
+# NOT IN USE:
+# sync symbolic links if the remote filesystem supports it.
+#sync_symbolic_links = false

src/csync_private.h

@@ -116,6 +116,7 @@ struct csync_s {
 
 enum csync_ftw_type_e {
   CSYNC_FTW_TYPE_FILE,
+  CSYNC_FTW_TYPE_SLINK,
   CSYNC_FTW_TYPE_DIR
 };
 

src/csync_propagate.c

@@ -537,6 +537,8 @@ static int _csync_propagation_file_visitor(void *obj, void *data) {
   ctx = (CSYNC *) data;
 
   switch(st->type) {
+    case CSYNC_FTW_TYPE_SLINK:
+      break;
     case CSYNC_FTW_TYPE_FILE:
       switch (st->instruction) {
         case CSYNC_INSTRUCTION_NEW:
@@ -583,6 +585,9 @@ static int _csync_propagation_dir_visitor(void *obj, void *data) {
   ctx = (CSYNC *) data;
 
   switch(st->type) {
+    case CSYNC_FTW_TYPE_SLINK:
+      /* FIXME: implement symlink support */
+      break;
     case CSYNC_FTW_TYPE_FILE:
       break;
     case CSYNC_FTW_TYPE_DIR:

src/csync_update.c

@@ -161,24 +161,20 @@ static int csync_detect_update(CSYNC *ctx, const char *file, const csync_vio_fil
 int csync_walker(CSYNC *ctx, const char *file, const csync_vio_file_stat_t *fs, enum csync_ftw_flags_e flag) {
   switch (flag) {
     case CSYNC_FTW_FLAG_FILE:
+      CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "file: %s", file);
+
+      return csync_detect_update(ctx, file, fs, CSYNC_FTW_TYPE_FILE);
+      break;
     case CSYNC_FTW_FLAG_SLINK:
-      switch (fs->mode & S_IFMT) {
-        case S_IFREG:
-          CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "file: %s", file);
-
-          return csync_detect_update(ctx, file, fs, CSYNC_FTW_TYPE_FILE);
-          break;
-        case S_IFLNK:
-          /* TODO: check if plugin supports symlinks */
-          if (ctx->options.sync_symbolic_links) {
-            CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "symlink: %s", file);
-
-            return csync_detect_update(ctx, file, fs, CSYNC_FTW_TYPE_FILE);
-          }
-          break;
-        default:
-          break;
+      /* FIXME: implement support for symlinks, see csync_propagate.c too */
+#if 0
+      if (ctx->options.sync_symbolic_links) {
+        CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "symlink: %s", file);
+
+        return csync_detect_update(ctx, file, fs, CSYNC_FTW_TYPE_SLINK);
       }
+#endif
+      break;
     case CSYNC_FTW_FLAG_DIR: /* enter directory */
       CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "directory: %s", file);