Add contacts menu integration

[ChristophWurst]

WIP - requires nextcloud/server#3233

TODO

• Correct namespacing
• Routing
• Hide other contacts, e.g. from the system address book Contacts menu server#3233 (comment)

[codecov-io]

Codecov Report

Merging #173 into master will decrease coverage by 0.41%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage      16%   15.58%   -0.42%     
==========================================
  Files          50       52       +2     
  Lines        1050     1142      +92     
==========================================
+ Hits          168      178      +10     
- Misses        882      964      +82

Impacted Files	Coverage Δ
...s/components/contactList/contactList_controller.js	1.76% <0%> (+0.55%)	⬆️
js/main.js	83.33% <50%> (-16.67%)	⬇️
js/services/contact_service.js	0.74% <0%> (-0.27%)	⬇️
...s/components/addressBook/addressBook_controller.js	2.12% <0%> (-0.15%)	⬇️
...onents/contactDetails/contactDetails_controller.js	2% <0%> (ø)	⬆️
js/components/groupList/groupList_controller.js	6.66% <0%> (ø)	⬆️
js/filters/counterFormatter_filter.js	100% <0%> (ø)
js/components/select_directive.js	11.11% <0%> (ø)
js/models/contact_model.js	41% <0%> (+0.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186eb31...737d63f. Read the comment docs.

[jancborchardt]

@ChristophWurst is this already up for first review or too much in-development state? :)

[ChristophWurst]

still WIP

[jancborchardt]

A few bugs so far:

• The list in the Contacts menu shouldn’t show yourself at all. nextcloud/server@cc3edca
• Neither the »i« Details icon for internal users. :) (At least not yet where we don’t have a detail page for them.) 07f1bb1
• When clicking on a details icon for a contact, it opens the Contacts app and loads the first contact as usually when opening the app. It should load that specific contact though.

cc @nextcloud/contacts help appreciated. :)

[ChristophWurst]

Hide other contacts, e.g. from the system address book nextcloud/server#3233 (comment)

@nextcloud/contacts any idea how I can distinguish between vcards from the system address book and the user address book? The data structures looks similar unfortunately, there's nothing specific to contacts from the contacts app it seems 🤔

[nickvergessen]

If you have access to the URI, it should contain system/system

[ChristophWurst]

If you have access to the URI, it should contain system/system

Thanks. Apparently the URI for system contacts is their UID. However, I've found what I was looking for: isLocalSystemBook is set for system contacts 😂

[jancborchardt]

Will this still show their email address though? Because that can be set in the personal details. :) The only thing which should be hidden is the details icon, not the whole entry.

[ChristophWurst]

email actions are added by the server, also for internal users

[ChristophWurst]

it doesn't hide the entry. it just doesn't add any action 😉

[ChristophWurst]

When clicking on a details icon for a contact, it opens the Contacts app and loads the first contact as usually when opening the app. It should load that specific contact though.

@skjnldsv you mentioned that it's easy to add that. Could you please tell me where I have to adjust the code? I presume it starts with a dedicated route in main.js. But how do I get the gid of that contacts to be able to redirect to /gid/uid? Is that even possible?

[ChristophWurst]

@skjnldsv you mentioned that it's easy to add that. Could you please tell me where I have to adjust the code? I presume it starts with a dedicated route in main.js. But how do I get the gid of that contacts to be able to redirect to /gid/uid? Is that even possible?

Kinda figured out how to possibly do that: 026d509
Still, that route doesn't seem to work when I'm already in the contacts app. It then always shows the first entry.
cc @nextcloud/contacts

[irgendwie]

@ChristophWurst found the reason (https://github.com/nextcloud/contacts/blob/contactsmenu-integration/js/components/contactList/contactList_controller.js#L142) and fixed it with a commit.

Will make some changes to the url design in a follow-up pr ref. owncloud/contacts#45 (comment)

[ChristophWurst]

@irgendwie thanks a lot \o/

[jancborchardt]

Can’t see any immediate issues 👍