fix: propagate group name changes #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure I see the the purpose of this change. the name only stores groupid, not the display name |
|
@st3iny @ArtificialOwl can you provide each other a bit more context to move this PR forward, thank you very much 🙏 |
|
I linked the issue in the PR description. The issue contains concrete steps to reproduce the problem. My observations: Renaming a group does not trigger renaming the mapped group inside circles. Somehow, it seems that the group rename event is not listened to and handled. |
|
From the ticket: Steps to reproduce
Observe that the group is still listed with the former name Expected behaviourThe new name should be used in Circles. Actual behaviourThe initial user group name is used everywhere which is confusing. Server configurationNextcloud version: master (as of today) |
ArtificialOwl
force-pushed
the
fix/propagate-group-rename
branch
from
dde3a4e to
83d3dbc
Compare
provokateurin
approved these changes
Feb 17, 2025
|
@st3iny cs-fixer is unhappy |
artonge
reviewed
Feb 17, 2025
Signed-off-by: Richard Steinmetz <[email protected]> Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
provokateurin
force-pushed
the
fix/propagate-group-rename
branch
from
83d3dbc to
528129b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #1828
Does not fully solve the linked issue.
Remaining problem: Existing members are not updated. Only the group circle.