fix(calendar-list): restrict calendar visibility toggle to checkbox only #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clicking anywhere on the calendar name would toggle its visibility, leading to accidental hiding of calendars. Now the visibility can only be toggled by clicking the checkbox/bullet icon. Fixes nextcloud#3027 Signed-off-by: Antonia Schwennesen <[email protected]>
zophiana
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6681 +/- ##
============================================
- Coverage 23.00% 22.99% -0.01%
Complexity 475 475
============================================
Files 252 252
Lines 12112 12116 +4
Branches 2310 2310
============================================
Hits 2786 2786
- Misses 8999 9003 +4
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
reviewed
Jan 29, 2025
Comment on lines
+9
to
+16
| :menu-open.sync="menuOpen"> | ||
| <template #icon> | ||
| <AppNavigationIconBullet v-if="calendar.enabled" | ||
| :color="calendar.color" | ||
| @click.prevent.stop="toggleEnabled" /> | ||
| <AppNavigationIconBullet v-else | ||
| :color="calendar.color" | ||
| @click.prevent.stop="toggleEnabled" /> |
There was a problem hiding this comment.
Suggested change
| :menu-open.sync="menuOpen"> | |
| <template #icon> | |
| <AppNavigationIconBullet v-if="calendar.enabled" | |
| :color="calendar.color" | |
| @click.prevent.stop="toggleEnabled" /> | |
| <AppNavigationIconBullet v-else | |
| :color="calendar.color" | |
| @click.prevent.stop="toggleEnabled" /> | |
| :menu-open.sync="menuOpen"> | |
| <template #icon> | |
| <AppNavigationIconBullet :color="calendar.color" /> |
This is actually a bug. Toggling should not be available in public views because the enabled state cannot be persisted anyway.
st3iny
added
bug
design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, clicking anywhere on the calendar name would toggle its visibility, leading to accidental hiding of calendars. Now the visibility can only be toggled by clicking the checkbox/bullet icon.
Fixes #3027