Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable5.1] fix: show display name instead of user id in availability integration #6675

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[stable5.1] fix: show display name instead of user id in availability integration #6675

merged 1 commit into from
Jan 28, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 28, 2025

Backport of PR #6674

@backportbot backportbot bot requested a review from ChristophWurst January 28, 2025 08:31
@backportbot backportbot bot added 3. to review Waiting for reviews bug Feature: Integration An integration with another app in the ecosystem labels Jan 28, 2025
@backportbot backportbot bot added this to the v5.1.0 milestone Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.54%. Comparing base (8f9d4ca) to head (bf683e0).
Report is 8 commits behind head on stable5.1.

Files with missing lines Patch % Lines
src/views/ContactsMenuAvailability.vue 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           stable5.1    #6675   +/-   ##
==========================================
  Coverage      14.54%   14.54%           
==========================================
  Files            210      210           
  Lines           9820     9820           
  Branches        2299     2310   +11     
==========================================
  Hits            1428     1428           
  Misses          8065     8065           
  Partials         327      327
Flag Coverage Δ
javascript 14.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChristophWurst
ChristophWurst reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clarify #6674 (review) first

@st3iny st3iny merged commit ed868e4 into stable5.1 Jan 28, 2025
38 of 39 checks passed
@st3iny st3iny deleted the backport/6674/stable5.1 branch January 28, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug Feature: Integration An integration with another app in the ecosystem
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @st3iny