Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): hide alarm actions menu when starting to edit #5621

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Dec 12, 2023

Fix #5617

2023-12-12.14-38-15.mp4

@st3iny st3iny added 3. to review Waiting for reviews bug Feature: Editor regression Regression of a previous working feature labels Dec 12, 2023
@st3iny st3iny added this to the v4.7.0 milestone Dec 12, 2023
@st3iny st3iny self-assigned this Dec 12, 2023
@st3iny
Copy link
Member Author

st3iny commented Dec 12, 2023

/backport to stable4.6

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6318d5f) 24.53% compared to head (25a6f13) 24.52%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/components/Editor/Alarm/AlarmListItem.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5621      +/-   ##
============================================
- Coverage     24.53%   24.52%   -0.01%     
  Complexity      418      418              
============================================
  Files           243      243              
  Lines         10785    10788       +3     
  Branches       1755     1756       +1     
============================================
  Hits           2646     2646              
- Misses         8139     8142       +3     
Flag Coverage Δ
javascript 15.57% <0.00%> (-0.01%) ⬇️
php 61.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD merged commit 93c0601 into main Dec 13, 2023
35 of 37 checks passed
@GretaD GretaD deleted the fix/sidebar/hide-alarm-menu-on-edit branch December 13, 2023 09:02
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Feature: Editor regression Regression of a previous working feature
Projects
Development

Successfully merging this pull request may close these issues.

Edit Date - selection for "minute, day, ..." don't work as expected
2 participants