Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special dialog when editing repeating events [$145] #7

Closed
georgehrke opened this issue Sep 17, 2016 · 45 comments · Fixed by #926
Closed

special dialog when editing repeating events [$145] #7

georgehrke opened this issue Sep 17, 2016 · 45 comments · Fixed by #926
Assignees
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Editor priority skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Milestone

Comments

@georgehrke
Copy link
Member

georgehrke commented Sep 17, 2016

When editing a repeating event the calendar needs a special dialog:

Do you want to change only this or this and all upcoming occurrences?


Did you fix this issue? Go claim the $145 bounty on Bountysource.

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of Feature: Editor skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills priority labels Sep 17, 2016
@georgehrke georgehrke added this to the 1.6-next milestone Sep 17, 2016
@georgehrke georgehrke changed the title special dialog when exigent repeating events special dialog when editing repeating events Sep 18, 2016
@georgehrke
Copy link
Member Author

requires #142 to be fixed

@bohni
Copy link

bohni commented Jan 30, 2017

There should be three possibilities:

  • Only this event (eg. delete/change)
  • This and all upcoming events (eg. delete/change)
  • All events (eg. typo in title),

@georgehrke
Copy link
Member Author

I honestly don't see a need for three options. The two mentioned in the description should be just fine.

All events (eg. typo in title),

You usually don't spot a typo in a title 3 month after creating it. You will most certainly spot it right after creating the event.
Editing past events happens very very rarely. Ordinary users probably never change past events.

The ordinary use cases here are:

  • location changes for one or all future occurrences. You wouldn't change the location for past events, because they already took place.
  • same goes for additional attendees. New attendees for one or all future occurrences didn't attend the previous events, so why add them?
  • deleting one or all future occurrences. The past ones still took place, so why remove them?

Having two or three buttons is a big difference from a usability point of view. The user has more input to parse. It clutters the interface and makes it less intuitive to use.

Would be good to get more input here. @nextcloud/calendar @jancborchardt @eppfel

@claell
Copy link

claell commented Jan 30, 2017

To me it seems strange to not have the option to change all events, although it might not be necessary.

Regarding typos: There can also be ones spotted some time after creation.

@raimund-schluessler
Copy link
Member

Just for the record, Thunderbird gives

  • Edit just this occurrence
  • Edit all occurrences

However, I would show

  • Edit just this occurrence
  • Edit all future occurrences

And if 'now' is given by the selected event, you could still edit past events by navigating to the first occurrence and edit this one with 'all future occurrences' which would lead to effectively editing all occurrences.

@heikojansen
Copy link

Both Google Calendar and Novell GroupWise offer all three options (with GCal apparently resetting prior modifications to other events if "edit all events" is selected).

@bohni
Copy link

bohni commented Jan 31, 2017

Lotus Notes even has 4 options:

  • Only this entry
  • All Entries
  • This and all previous entries
  • This and all future entries

And I would like to have the possibility to delete all entries, whether or not they took place.

@georgehrke
Copy link
Member Author

This and all previous entries

Seems like Lotus Notes is still stuck on the first revision of the icalendar standard 🙈
I can't think of any legitimate use case for that.

@bohni
Copy link

bohni commented Jan 31, 2017

I know (http://dreckstool.de/hitlist.do), that's because I first wrote about three options. And still will vote for 3 options... :-)

@github-user-1
Copy link

I opt for three options - a) this event, b) all future events, and c) all events. This is how it also done by Google-Calendar which is used by millions of people and seems to be the right way in my viewpoint to offer changes for recurring events.

@skjnldsv
Copy link
Member

I won't mind three options imho.
But I also agree with @georgehrke pov. Too much information isn't suitable. But I could also see some uses for me that would require editing passed events too :/

@georgehrke
Copy link
Member Author

georgehrke commented Apr 7, 2017

Reminder to myself:

  • don't use RECURRENCE-ID;RANGE=THISANDFUTURE. Support of most clients is very poor for this.
  • split up event and set UNTIL on old event instead.

macOS and iOS don't support RANGE=THISANDFUTURE. According to http://stackoverflow.com/a/30343374 Google calendar does neither.

Looking at the code, lightning should actually support RANGE=THISANDFUTURE, but will work fine with splitting the event up too.
lightning (on macOS) supports it neither

@georgehrke
Copy link
Member Author

requires #413

@strk
Copy link

strk commented May 4, 2017

#413 was merged, so this is open for work shall anyone want to help :)

@dehart
Copy link

dehart commented May 4, 2017

Be aware that when attendees are invited to the event they get 2 emails

  • an update: the current event is ending
  • an invite: new series that has started.

Range property solves this but these are my test results:

Sad but true
Test file:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//GEDIT//NONSGML Version 1//EN
BEGIN:VEVENT
UID:1337-range-test@michael
DTSTART;VALUE=DATE:20170501
DURATION:P1D
DTSTAMP:20170401T160000Z
RRULE:FREQ=WEEKLY
STATUS:CONFIRMED
SUMMARY:Range-test: Weekly
END:VEVENT
BEGIN:VEVENT
UID:1337-range-test@michael
RECURRENCE-ID;RANGE=THISANDFUTURE;VALUE=DATE:20170605
DTSTART;VALUE=DATE:20170605
DURATION:P1D
DTSTAMP:20170401T160000Z
SUMMARY:Range-test: Changed
END:VEVENT
END:VCALENDAR

@georgehrke
Copy link
Member Author

@dehart As I said just two comments above, let's not use range, just split up and set until on the first one. ;)

#7 (comment)

@jospoortvliet jospoortvliet changed the title special dialog when editing repeating events [$95] special dialog when editing repeating events [$120] Mar 26, 2019
@scroom
Copy link

scroom commented May 7, 2019

I just raised the bounty with $25.

@Tokowo

This comment has been minimized.

@karloluiten

This comment has been minimized.

@georgehrke

This comment has been minimized.

@Tokowo

This comment has been minimized.

@torpak

This comment has been minimized.

@tcitworld
Copy link
Member

People, please stop replying to off-topic messages or we'll have to lock the issue.

@dbadura

This comment has been minimized.

@georgehrke georgehrke pinned this issue Jul 8, 2019
@georgehrke georgehrke modified the milestones: 2.2.0, 2.0.0 beta1 Aug 25, 2019
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 9, 2019
@tcitworld tcitworld unpinned this issue Oct 20, 2019
@kritschy
Copy link

Would be nice, if an e.g. every month repeated event could be stopped in a certain period.

@sherpadawan
Copy link

Any news ? Does not seem to work now on the last agenda plugin version !

@executed
Copy link

Is there a reason or active issue why this was added only as a button in the event details view and not also as a prompt when just shifting the event's time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Editor priority skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet