docs(README): Expand and re-organize everything #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New sections * Helps the reader address nuisance triggers properly * Explains what disabling this app accomplishes/doesn't accomplish * Addresses versioning/releases/tagging topic since this is now a shipped app (fixes #500 as much as is realistic outside of publishing newer versions in the app store which isn't presently expected for shipped apps) * Adds numerous related documentation links for things often confused with this app (e.g. `suspicious_login` app, using `fail2ban` with Nextcloud, etc) * A basic usage section * Adds help & contributing links Signed-off-by: Josh <[email protected]>
joshtrichards
requested review from
nickvergessen,
jancborchardt,
DorraJaouad and
AndyScherzinger
Signed-off-by: Josh <[email protected]>
nickvergessen
approved these changes
Feb 13, 2024
DorraJaouad
approved these changes
Feb 13, 2024
AndyScherzinger
approved these changes
Feb 13, 2024
Merged
8 tasks
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suspicious_loginapp, usingfail2banwith Nextcloud, etc)Closes #500 (as much as is realistic outside of publishing newer versions in the app store which isn't presently expected for shipped apps)
Screenshot:
(ignore the artifact above the "How it works" heading, which is just some weird bug in Firefox's screenshot feature that gets triggered on this page)