Sharing UI

[marcelklehr]

Sharing user:

Sharee:

Public link

[jancborchardt]

Wow, this is very very cool! My only feedback is kinda unrelated. :D

• On the sharing page, the title subline is black but should be white
• Instead of breadbrumbs, we should use the system that Photos uses with the nice large headings

So 👍 from me

[skjnldsv]

• Instead of breadbrumbs, we should use the system that Photos uses with the nice large headings

I think there is an issue already.
Let's stay relevant to this issue ;)

[jancborchardt]

• Instead of breadbrumbs, we should use the system that Photos uses with the nice large headings

I think there is an issue already.
Let's stay relevant to this issue ;)

Exactly why I simply gave my 👍 and said it’s unrelated. ;)

[marcelklehr]

Ah, nice I hadn't seen the photos app approach, yet :)

On the sharing page, the title subline is black but should be white

I was baffled by that as well. I'm using the PublicPageTemplate to set those, so I wasn't sure whether I should style that myself, or if this is an upstream bug.

[skjnldsv]

Please rebase ;)
Tests should be running now, I feel more confident reviewing this pr now :)

[marcelklehr]

The server-side tests are broken, atm, I will work on this laters

[marcelklehr]

I should get those complexity numbers down... 😅

[jancborchardt]

So @skjnldsv will be able to talk about this more, but the Sharing UI would be a good candidate for a component in the Vue components library :) https://github.com/nextcloud/nextcloud-vue

[codecov-io]

Codecov Report

Merging #952 into master will decrease coverage by 1.10%.
The diff coverage is 13.70%.

@@             Coverage Diff              @@
##             master     #952      +/-   ##
============================================
- Coverage     41.81%   40.70%   -1.11%     
- Complexity      764      785      +21     
============================================
  Files            51       51              
  Lines          2810     2874      +64     
============================================
- Hits           1175     1170       -5     
- Misses         1635     1704      +69     

Impacted Files	Coverage Δ	Complexity Δ
appinfo/routes.php	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
lib/AppInfo/Application.php	0.00% <0.00%> (ø)	2.00 <0.00> (ø)
lib/Controller/InternalFoldersController.php	0.00% <0.00%> (ø)	17.00 <0.00> (ø)
lib/Controller/WebViewController.php	0.00% <0.00%> (ø)	6.00 <5.00> (+4.00)
lib/Db/ShareMapper.php	29.50% <ø> (-9.84%)	10.00 <0.00> (ø)
...b/Migration/Version003000000Date20191123094721.php	0.00% <0.00%> (ø)	16.00 <0.00> (+12.00)
...b/Migration/Version003000000Date20191129094721.php	0.00% <ø> (ø)	4.00 <0.00> (-5.00)
lib/Service/BookmarkPreviewer.php	0.00% <0.00%> (ø)	6.00 <0.00> (ø)
lib/Controller/FoldersController.php	45.29% <38.77%> (-2.88%)	132.00 <11.00> (+4.00)	⬇️
lib/Controller/BookmarkController.php	38.57% <50.00%> (+0.40%)	126.00 <0.00> (-1.00)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef88b8c...834a8ba. Read the comment docs.

[marcelklehr]

@skjnldsv This is good to review now :)

[ccoenen]

omg-its-happening.gif here. Thanks everyone! Looking forward to the release!

[jancborchardt]

Props @marcelklehr, really good work! :)