Makes imaginary port configurable #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenmalisi
force-pushed
the
feature/imaginary-port
branch
from
7348786 to
af3bb1d
Compare
Zoey2936
reviewed
May 11, 2023
Zoey2936
approved these changes
May 11, 2023
szaimen
reviewed
May 11, 2023
szaimen
added
3. to review
26 tasks
Signed-off-by: steffenmalisi <[email protected]>
Signed-off-by: steffenmalisi <[email protected]>
szaimen
force-pushed
the
feature/imaginary-port
branch
from
819956b to
7df7ee7
Compare
szaimen
approved these changes
May 12, 2023
|
This is now released with v5.2.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Works in my setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit 6fe6d7e the imaginary image lost the possibility of manually configuring the port imaginary listens to.
The original image, where this one was based on (https://github.com/h2non/imaginary/blob/master/Dockerfile), does support defining the port as ENV variable.
This PR introduces this capability again, also for AIO.
Why is it needed? In my case I am running some of the AIO containers in one Podman pod. Within a pod all containers share the same network namespace. Because php fpm and imaginary are using port 9000 by default, I welcomed the possibility of the imaginary image to change the default port.