Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize nextcloud Dockerfile #2497

Merged
merged 4 commits into from
May 30, 2023
Merged

optimize nextcloud Dockerfile #2497

merged 4 commits into from
May 30, 2023

Conversation

Zoey2936
Copy link
Collaborator

@Zoey2936 Zoey2936 commented May 3, 2023

No description provided.

@Zoey2936 Zoey2936 requested a review from szaimen May 3, 2023 14:32
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels May 3, 2023
@szaimen szaimen added this to the next milestone May 3, 2023
@szaimen szaimen mentioned this pull request May 3, 2023
Closed
35 tasks
@szaimen szaimen modified the milestones: v5.1.0, next May 4, 2023
@szaimen szaimen mentioned this pull request May 11, 2023
Closed
26 tasks
@szaimen szaimen modified the milestones: v5.2.0, next, v5.2.1, v5.2.2 May 19, 2023
@szaimen szaimen force-pushed the nextcloud-dockerfile branch from 40891af to 651d134 Compare May 26, 2023 12:44
@szaimen szaimen mentioned this pull request May 26, 2023
Closed
31 tasks
Zoey2936 and others added 2 commits May 30, 2023 11:50
@szaimen szaimen force-pushed the nextcloud-dockerfile branch from 4472d35 to d18b58d Compare May 30, 2023 09:50
@szaimen
Copy link
Collaborator

szaimen commented May 30, 2023

@Zoey2936 do my changes look good to you?

@szaimen
adjust review
675de94 
Signed-off-by: Simon L <[email protected]>
@szaimen szaimen force-pushed the nextcloud-dockerfile branch from 29b05d7 to 675de94 Compare May 30, 2023 10:00
@Zoey2936
Copy link
Collaborator Author

@Zoey2936 do my changes look good to you?

if the build doesn‘t fail, yes

@szaimen
Copy link
Collaborator

szaimen commented May 30, 2023

if the build doesn‘t fail, yes

works now :)

@szaimen szaimen removed the 3. to review Waiting for reviews label May 30, 2023
@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label May 30, 2023
@Zoey2936
Copy link
Collaborator Author

so volumes, are not required?

@szaimen
fix build
c854e68 
Signed-off-by: Simon L <[email protected]>
@szaimen szaimen force-pushed the nextcloud-dockerfile branch from 5d9470d to c854e68 Compare May 30, 2023 10:23
@szaimen
Copy link
Collaborator

szaimen commented May 30, 2023

so volumes, are not required?

Not necessarily but I've added them back.

szaimen
szaimen approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen merged commit 0b50fbd into main May 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the nextcloud-dockerfile branch May 30, 2023 11:01
@Zoey2936
Copy link
Collaborator Author

nearly 150MB
grafik

@szaimen
Copy link
Collaborator

szaimen commented May 30, 2023

nearly 150MB grafik

Yes, I saw it. Thanks for tackling this! 💙🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zoey2936 @szaimen