-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to add dependencies and php extensions into the Nextcloud container #1377
Conversation
4098d5d
to
00a85a1
Compare
@Zoey2936 WDYT? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should work, but I think it would also be good to have an option to install packages using
npm install --global <package> - requieres to have npm installed using apk
yarn global add <package> - requieres to have yarn installed using apk
pip install <packages> - requieres to have py3-pip installed using apk
Because for example the NCDownloader app requires installing yt-dlp using pip (which requires gcc, musl-dev and py3-pip to be installed using apk)
I currently don't know if any npm/yarn packages is needed by any nextcloud app existing, but I think at some point in the future it could be also needed
https://pkgs.alpinelinux.org/packages?name=youtube-dl&branch=v3.16&repo=&arch=&maintainer= |
There is a difference between youtube-dl and yt-dlp |
https://pkgs.alpinelinux.org/packages?name=yt-dlp&branch=v3.16&repo=&arch=&maintainer= |
Then apk packages and php extension should be enough, then there is only the |
…iner Signed-off-by: Simon L <[email protected]>
00a85a1
to
da2b967
Compare
17add46
to
e720e07
Compare
Signed-off-by: Simon L <[email protected]>
e720e07
to
135ed21
Compare
Signed-off-by: Simon L <[email protected]>
135ed21
to
fb7d5e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks Zoey! :) |
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
good catch. Let me add this... |
to review: #1387 |
Close #1162
Signed-off-by: Simon L [email protected]