add docker healthchecks to the docker images #1027
Conversation
Signed-off-by: Sanoj <[email protected]> Signed-off-by: Sanoj <[email protected]>
Signed-off-by: Sanoj <[email protected]> Signed-off-by: Sanoj <[email protected]>
Signed-off-by: Sanoj <[email protected]>
|
@Z0ey2022 Thanks for the PR! I'll have a look soon! |
|
Short question: why do you/we need these health checks? |
I don't need them directly, but I like it when I see that my containers report not only that they are running, but also show that they are healthy, so that I could see if the service inside the container is stopped or crashed or something like this Maybe the mastercontainer could also check the status of the container from the docker socket and show the status also inside the aio panel or do something else with this information, but I don't know if this could work or how this could be implemented |
szaimen
added
3. to review
|
I will wait for #1044 to be merged, so I can directly add a Healthcheck for elastic search |
Zoey2936
added
2. developing
Signed-off-by: Zoey <[email protected]>
Zoey2936
added
3. to review
Signed-off-by: Zoey <[email protected]>
Containers/fulltextsearch/Dockerfile
Outdated
| @@ -2,3 +2,5 @@ | |||
| FROM elasticsearch:7.17.6 | |||
|
|
|||
| RUN elasticsearch-plugin install --batch ingest-attachment | |||
|
|
|||
| HEALTHCHECK CMD curl -skfI localhost:9200 || exit 1 | |||
There was a problem hiding this comment.
we don't need this as the base image already includes the healthcheck. See https://github.com/elastic/elasticsearch/blob/8b3293ddeb008459bf795cb4082beab3d654cd88/distribution/docker/src/docker/Dockerfile#L295
There was a problem hiding this comment.
I think it is needed
There was a problem hiding this comment.
Strange! Seems like you are right.
There was a problem hiding this comment.
I think the reason is this if condition
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
|
LGTM now! Please rebase on top of master and squash your changes. Afterwards I'll merge! |
Sorry, but I don't get them rebased, should I create a new PR with these changes? |
Fine by me if that is easier for you 👍 |
Added Docker Health checks to some containers.
clamav container already includes this.
And for the watchtower & borgbackup container I don't know how this could be done, and I think, because they only run for a short time, it wouldn't make much sense to add this check to them.
In my test (I connected using bash, for example:
docker exec -it nextcloud-aio-collabora bash, the executed the health check commands and then checked withecho $?) all checks reported Exit Code 0.