Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNavigation: fix style for CSS class "active" #593

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

korelstar
Copy link
Contributor

Since #486, #app-navigation has CSS class vue and Nextcloud server has the following style:

#app-navigation:not(.vue) > ul > li.active, #app-navigation:not(.vue) > ul > li a:hover, #app-navigation:not(.vue) > ul > li a:focus, #app-navigation:not(.vue) > ul > li a:active, #app-navigation:not(.vue) > ul > li a.selected, #app-navigation:not(.vue) > ul > li a.active, #app-navigation:not(.vue) > ul > li.active > a, #app-navigation:not(.vue) > ul > li a:hover > a, #app-navigation:not(.vue) > ul > li a:focus > a, #app-navigation:not(.vue) > ul > li a:active > a, #app-navigation:not(.vue) > ul > li a.selected > a, #app-navigation:not(.vue) > ul > li a.active > a {
	opacity: 1;
	box-shadow: inset 4px 0 var(--color-primary);
}

This means, that the active style from server is not applied anymore to AppNavigationItem. However, the component doesn't include it's own style for active CSS class. This is fixed with this PR.

@korelstar korelstar added bug Something isn't working feature: app-navigation Related to the app-navigation component labels Sep 14, 2019
@skjnldsv
Copy link
Contributor

Ah, we have an ongoing discussion about this in #425 :)
Which will also be applied to the navigation, so we'll wait for it to be integrated I think! @ma12-co ?

@korelstar
Copy link
Contributor Author

I'm aware of that. But it's unclear when this will be implemented. Currently, there is no way to identify the active item at all. Therefore, I think this intermediate quick-fix is helpful. Otherwise, testing an app using master is very annoying.

@skjnldsv
Copy link
Contributor

@korelstar ahah, sorry :)
Let's merge this then sure!

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Sep 14, 2019
@skjnldsv skjnldsv merged commit 7b44e9f into master Sep 14, 2019
@skjnldsv skjnldsv deleted the fix-active branch September 14, 2019 21:13
@skjnldsv skjnldsv added this to the 0.13.0 milestone Oct 3, 2019
@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 3, 2019

/backport to stable0-12

@backportbot-nextcloud
Copy link

The backport to stable0-12 failed. Please do this backport manually.

@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 3, 2019

Ah no, too different, let's keep on 13.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants