Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darken modal mask background for better focus #300

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Darken modal mask background for better focus #300

merged 1 commit into from
Mar 13, 2019

Conversation

jancborchardt
Copy link
Contributor

Before & after, please review @nextcloud/designers

modal background before

modal background after

@jancborchardt
Darken modal mask background for better focus
7aab648 
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
@jancborchardt jancborchardt added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: modal Related to the modal component labels Mar 12, 2019
This was referenced Mar 12, 2019
Closed
Merged
MorrisJobke
MorrisJobke approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@skjnldsv skjnldsv merged commit 6b52302 into master Mar 13, 2019
@skjnldsv skjnldsv deleted the design/modal-background branch March 13, 2019 13:01
@skjnldsv skjnldsv added this to the next milestone Mar 13, 2019
@skjnldsv skjnldsv modified the milestones: next, 0.9.1-0.9.4 Mar 26, 2019
@skjnldsv skjnldsv mentioned this pull request Sep 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: modal Related to the modal component
Projects
None yet
Milestone
0.9.1-0.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jancborchardt @MorrisJobke @skjnldsv