Increase padding right of AppNavigationItem to 8 px #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
changed the title
raimund-schluessler
requested review from
nimishavijay,
skjnldsv,
GretaD and
ChristophWurst
skjnldsv
approved these changes
Dec 15, 2021
marcoambrosini
approved these changes
Dec 15, 2021
|
/backport to stable4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative to #2406. We increase the padding-right of
AppNavigationItemto 8 px here.The result is the same, the
ActionsMenus ofAppNavigationItem,AppNavigationCaptionandListItemare nicely aligned, they just all have a right-padding of 8 px here:Make your choice between #2406 and this one and approve the PR you like better 😉