-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): allow and recommend to provide a specific root #574
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 160 170 +10
Branches 45 50 +5
=========================================
+ Hits 160 170 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: John Molakvoæ <[email protected]>
What will the root be used for? |
Specifying the workdir for example. Like currently, if I get files from webdav and process them into I could put them into the attributes, but I think it's cleaner as an official implementation. |
If you take the source, remove basename and dirname you already get the root, don't you? It sounds like there will be two approaches to achieve the same goal. Either you spec basename and dirname or source and root? |
Well, you don't know the root
Here the roots are respectively:
And we cannot detect this, so we have to manually be able to provide that information |
This should ensure we are working from a specific point
This makes sense for most dav ressources