-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File and Folder API #501
Conversation
skjnldsv
commented
Sep 30, 2022
•
edited
Loading
edited
Codecov ReportBase: 97.18% // Head: 98.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 97.18% 98.68% +1.50%
==========================================
Files 4 10 +6
Lines 71 152 +81
Branches 18 37 +19
==========================================
+ Hits 69 150 +81
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cac806a
to
a2f62ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐕
*/ | ||
get source(): string { | ||
// strip any ending slash | ||
return this._data.source.replace(/\/$/i, '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this imply that invalid data was passed to data.source
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just to help standardizing the source format a tiny bit. Would you prefer a more restrictive approach and throwing?
I wasn't sure about leaving the ending slash or not. :)
a2f62ec
to
9968784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
attributes would be usable for any webdav attributes not being part of the typed classes I guess? |
Yes, whatever we want that is not some kind of 'official' for a file or folder representation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, and as I said, I would go for prefixing the class names, NcFile, NcFolder, ...
to prevent confusion with default browser APIs.
9968784
to
b4ae6b1
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
b4ae6b1
to
e025fd7
Compare