Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileListAction): keep same method param pattern accross our APIs #1135

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 5, 2024

Addressing my comments from #1113

@skjnldsv skjnldsv added the 3. to review 3️⃣ Waiting for reviews label Dec 5, 2024
@skjnldsv skjnldsv requested a review from Pytal December 5, 2024 19:40
@skjnldsv skjnldsv self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (f1d1a84) to head (0d773f3).
Report is 84 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          23       23           
  Lines         633      633           
  Branches      166      166           
=======================================
  Hits          580      580           
  Misses         46       46           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Dec 5, 2024

Bundle Report

Bundle size has no change ✅

@skjnldsv skjnldsv merged commit 52dd3c8 into main Dec 12, 2024
18 checks passed
@skjnldsv skjnldsv deleted the fix/fileListAction-api branch December 12, 2024 08:10
@skjnldsv skjnldsv mentioned this pull request Dec 12, 2024
@susnux susnux added the type: bug 🐛 Something isn't working label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants