fix: Do not depend on the 'path' package for basename #765
Conversation
Sounds like the bundler configuration of that app is not configured correctly |
lib/commands/docker.ts
Outdated
| @@ -3,7 +3,10 @@ | |||
| * SPDX-License-Identifier: AGPL-3.0-or-later | |||
| */ | |||
|
|
|||
| import { basename } from 'path' | |||
| function basename(path: string): string { | |||
| return path.split(/[\\/]/).pop() ?? '' | |||
There was a problem hiding this comment.
I expect we are only on POSIX so backslash is a valid part of a filename
| return path.split(/[\\/]/).pop() ?? '' | |
| return path.split('/').pop() |
(also the result of split will always be an array with at least one string element and the result of pop always that element, so the nullish operator is useless).
There was a problem hiding this comment.
I expect we are only on POSIX so backslash is a valid part of a filename
Don't we have colleagues running Windows? But indeed, this could break if the filename contains \. Not sure how to best handle that.
(also the result of split will always be an array with at least one string element and the result of pop always that element, so the nullish operator is useless).
Typing was not happy. I added as string instead.
This is causing issues with ESM: "process is not defined". Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/usageimport
branch
from
068f73f to
7937921
Compare
This is causing issues with ESM: "process is not defined".
Include package version bump